feat!: Remove bedrock-specific tracker method#1385
Merged
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/browser size report |
jsonbailey
force-pushed
the
jb/bedrock-tracker-removal
branch
from
3552d62 to
1bc3966
Compare
andrewklatzke
approved these changes
May 19, 2026
Remove the trackBedrockConverseMetrics method from LDAIConfigTracker along with the createBedrockTokenUsage helper and the BedrockTokenUsage module. AWS Bedrock metric tracking will move to a dedicated @launchdarkly/server-sdk-ai-bedrock provider package, matching the pattern used by the OpenAI and LangChain providers. The getting-started/bedrock/converse example is kept and updated to use tracker.trackMetricsOf with an inline metrics extractor. This keeps the example functional and demonstrates the generic extractor pattern that the upcoming provider package will package as a helper. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jsonbailey
force-pushed
the
jb/bedrock-tracker-removal
branch
from
1bc3966 to
5d16dd4
Compare
Merged
jsonbailey
pushed a commit
that referenced
this pull request
May 19, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>browser: 0.1.21</summary> ## [0.1.21](browser-v0.1.20...browser-v0.1.21) (2026-05-19) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk bumped from 4.6.5 to 4.7.0 </details> <details><summary>jest: 1.0.16</summary> ## [1.0.16](jest-v1.0.15...jest-v1.0.16) (2026-05-19) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/react-native-client-sdk bumped from ~10.17.4 to ~10.17.5 </details> <details><summary>js-client-sdk: 4.7.0</summary> ## [4.7.0](js-client-sdk-v4.6.5...js-client-sdk-v4.7.0) (2026-05-19) ### Features * wire registerDebugOverrides through client common ([#1368](#1368)) ([9011c2a](9011c2a)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.26.3 to 1.27.0 </details> <details><summary>js-client-sdk-common: 1.27.0</summary> ## [1.27.0](js-client-sdk-common-v1.26.3...js-client-sdk-common-v1.27.0) (2026-05-19) ### Features * wire registerDebugOverrides through client common ([#1368](#1368)) ([9011c2a](9011c2a)) </details> <details><summary>react-native-client-sdk: 10.17.5</summary> ## [10.17.5](react-native-client-sdk-v10.17.4...react-native-client-sdk-v10.17.5) (2026-05-19) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.26.3 to 1.27.0 </details> <details><summary>react-sdk: 4.0.2</summary> ## [4.0.2](react-sdk-v4.0.1...react-sdk-v4.0.2) (2026-05-19) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk bumped from ^4.6.5 to ^4.7.0 </details> <details><summary>server-sdk-ai: 1.0.0</summary> ## [1.0.0](server-sdk-ai-v0.20.0...server-sdk-ai-v1.0.0) (2026-05-19) ### ⚠ BREAKING CHANGES * Remove bedrock-specific tracker method ([#1385](#1385)) * Remove `LDAIClient.agent` — use `LDAIClient.agentConfig` instead * Remove `LDAIClient.agents` — use `LDAIClient.agentConfigs` instead * Remove `LDAIClient.createChat` — use `LDAIClient.createModel` instead * Remove `LDAIClient.initChat` — use `LDAIClient.createModel` instead * Remove `ChatResponse` type and the `api/chat` module — use `RunnerResult` from `api/model` instead * Change `Judge.evaluateMessages` parameter type from `ChatResponse` to `RunnerResult` (method retained per AI SDK spec Requirement 1.1.3) * Remove `evaluationMetricKeys` (plural) field from `LDAIJudgeConfig` and `LDAIJudgeConfigDefault` — use `evaluationMetricKey` (singular) instead * Remove `LDAIConfigTracker.trackOpenAIMetrics` — use `tracker.trackMetricsOf(getAIMetricsFromResponse, fn)` from `@launchdarkly/server-sdk-ai-openai` instead * Remove `LDAIConfigTracker.trackVercelAISDKGenerateTextMetrics` — use `tracker.trackMetricsOf(getAIMetricsFromResponse, fn)` from `@launchdarkly/server-sdk-ai-vercel` instead * Remove `createOpenAiUsage` helper — use `getAIMetricsFromResponse` from `@launchdarkly/server-sdk-ai-openai` instead * Remove `createVercelAISDKTokenUsage` helper — use `getAIMetricsFromResponse` from `@launchdarkly/server-sdk-ai-vercel` instead * Remove `LDAIClient.config` — use `LDAIClient.completionConfig` instead ### Features * Change `Judge.evaluateMessages` parameter type from `ChatResponse` to `RunnerResult` (method retained per AI SDK spec Requirement 1.1.3) ([86951b0](86951b0)) * Remove `ChatResponse` type and the `api/chat` module — use `RunnerResult` from `api/model` instead ([86951b0](86951b0)) * Remove `createOpenAiUsage` helper — use `getAIMetricsFromResponse` from `@launchdarkly/server-sdk-ai-openai` instead ([86951b0](86951b0)) * Remove `createVercelAISDKTokenUsage` helper — use `getAIMetricsFromResponse` from `@launchdarkly/server-sdk-ai-vercel` instead ([86951b0](86951b0)) * Remove `evaluationMetricKeys` (plural) field from `LDAIJudgeConfig` and `LDAIJudgeConfigDefault` — use `evaluationMetricKey` (singular) instead ([86951b0](86951b0)) * Remove `LDAIClient.agent` — use `LDAIClient.agentConfig` instead ([86951b0](86951b0)) * Remove `LDAIClient.agents` — use `LDAIClient.agentConfigs` instead ([86951b0](86951b0)) * Remove `LDAIClient.config` — use `LDAIClient.completionConfig` instead ([86951b0](86951b0)) * Remove `LDAIClient.createChat` — use `LDAIClient.createModel` instead ([86951b0](86951b0)) * Remove `LDAIClient.initChat` — use `LDAIClient.createModel` instead ([86951b0](86951b0)) * Remove `LDAIConfigTracker.trackOpenAIMetrics` — use `tracker.trackMetricsOf(getAIMetricsFromResponse, fn)` from `@launchdarkly/server-sdk-ai-openai` instead ([86951b0](86951b0)) * Remove `LDAIConfigTracker.trackVercelAISDKGenerateTextMetrics` — use `tracker.trackMetricsOf(getAIMetricsFromResponse, fn)` from `@launchdarkly/server-sdk-ai-vercel` instead ([86951b0](86951b0)) * Remove bedrock-specific tracker method ([#1385](#1385)) ([f7dbee8](f7dbee8)) ### Bug Fixes * Make judge runners non-multi-turn ([#1383](#1383)) ([3d8f488](3d8f488)) * Move ManagedAgentGraph alongside other managed types ([#1384](#1384)) ([22dd76d](22dd76d)) </details> <details><summary>server-sdk-ai-langchain: 0.8.0</summary> ## [0.8.0](server-sdk-ai-langchain-v0.7.0...server-sdk-ai-langchain-v0.8.0) (2026-05-19) ### Features * Support conversation history directly in AI Provider model runners ([#1371](#1371)) ([b246631](b246631)) ### Bug Fixes * Make judge runners non-multi-turn ([#1383](#1383)) ([3d8f488](3d8f488)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/server-sdk-ai bumped from ^0.20.0 to ^1.0.0 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.20.0 to ^1.0.0 </details> <details><summary>server-sdk-ai-openai: 0.7.0</summary> ## [0.7.0](server-sdk-ai-openai-v0.6.0...server-sdk-ai-openai-v0.7.0) (2026-05-19) ### Features * Support conversation history directly in AI Provider model runners ([#1371](#1371)) ([b246631](b246631)) ### Bug Fixes * Make judge runners non-multi-turn ([#1383](#1383)) ([3d8f488](3d8f488)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/server-sdk-ai bumped from ^0.20.0 to ^1.0.0 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.20.0 to ^1.0.0 </details> <details><summary>server-sdk-ai-vercel: 0.7.0</summary> ## [0.7.0](server-sdk-ai-vercel-v0.6.0...server-sdk-ai-vercel-v0.7.0) (2026-05-19) ### Features * Support conversation history directly in AI Provider model runners ([#1371](#1371)) ([b246631](b246631)) ### Bug Fixes * Make judge runners non-multi-turn ([#1383](#1383)) ([3d8f488](3d8f488)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @launchdarkly/server-sdk-ai bumped from ^0.20.0 to ^1.0.0 * peerDependencies * @launchdarkly/server-sdk-ai bumped from ^0.20.0 to ^1.0.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Primarily a release/metadata PR (version bumps and changelog updates), but it includes a `@launchdarkly/server-sdk-ai` major version bump to `1.0.0`, which signals breaking API changes for downstream consumers. > > **Overview** > **Release-please version rollup.** Updates `.release-please-manifest.json`, package `version` fields, and associated `CHANGELOG.md` entries across the monorepo. > > Notable bumps include `@launchdarkly/server-sdk-ai` to **`1.0.0`** (breaking-change release per changelog) and propagation of dependency bumps (`@launchdarkly/js-client-sdk-common` to `1.27.0`, browser SDK to `4.7.0`, React Native to `10.17.5`, React SDK to `4.0.2`, and AI provider packages to `0.7.x/0.8.0`), along with updating embedded SDK/wrapper version strings (e.g., `BrowserInfo`, `PlatformInfo`, `LDReactClient`). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit bebd031. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LDAIConfigTracker.trackBedrockConverseMetricsfrom the interface and its implementation.createBedrockTokenUsagehelper and theBedrockTokenUsagemodule (no longer referenced).__tests__/TokenUsage.test.ts(file empty after removal, deleted) and the two bedrock cases in__tests__/LDAIConfigTrackerImpl.test.ts. Trim thetrackBedrockConverseMetricsjest-mock line from theManagedAgent,ManagedModel, andManagedModelRuntest mocks.examples/getting-started/bedrock/converseexample to usetracker.trackMetricsOfwith an inline metrics extractor instead of the removedtrackBedrockConverseMetricshelper. The upcoming@launchdarkly/server-sdk-ai-bedrockprovider package will ship an equivalent extractor as a reusable helper.Bedrock metric tracking is moving into a dedicated
@launchdarkly/server-sdk-ai-bedrockprovider package, matching the OpenAI and LangChain providers. A follow-up PR will add that package.This mirrors the equivalent removal already merged in
python-server-sdk-ai.feat!: Remove bedrock-specific tracker method from LDAIConfigTracker
Test plan
yarn workspaces foreach -pR --topological-dev --from '@launchdarkly/server-sdk-ai' run build— cleanyarn workspace @launchdarkly/server-sdk-ai test— 222/222 passing across 13 suitesyarn workspace @launchdarkly/server-sdk-ai lint— cleanyarn workspace bedrock-converse bootstrap— clean (transitive build)tsc --noEmiton the example — cleantrackBedrockConverseMetrics,createBedrockTokenUsage, orBedrockTokenUsageoutsidenode_modules🤖 Generated with Claude Code
Note
Medium Risk
Breaking API change removes the Bedrock-specific tracker method, requiring downstream Bedrock integrations to migrate to
trackMetricsOf/custom extractors. Runtime risk is low since behavior is largely preserved, but consumers may fail to compile until updated.Overview
Breaking change: removes
LDAIConfigTracker.trackBedrockConverseMetrics(and itsLDAIConfigTrackerImplimplementation), along with the Bedrock token-usage helper/module (createBedrockTokenUsage/BedrockTokenUsage).Updates the Bedrock Converse getting-started example to use
tracker.trackMetricsOfwith an inlineConverseCommandOutputmetrics extractor, and trims/deletes the related unit tests and mocks that referenced the removed Bedrock-specific APIs.Reviewed by Cursor Bugbot for commit 5d16dd4. Bugbot is set up for automated code reviews on this repo. Configure here.